dejankrak-db commented on code in PR #50434:
URL: https://github.com/apache/spark/pull/50434#discussion_r2017509653
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala:
##########
@@ -987,9 +984,15 @@ class SessionCatalog(
parser.parseQuery(viewText)
}
}
+ val plan = if (metadata.collation.isDefined) {
+ val newType = StringType(metadata.collation.get)
+ ResolveDDLCommandStringTypes.transformPlan(parsedPlan, newType)
Review Comment:
Will this path skip ResolveDDLCommandStringTypes analyzer rule? I.e. why do
we need to do this here separately?
What is the split of responsibilities between this code here and
ResolveDDLCommandStringTypes for CreateView command? Does either one or the
other gets executed solely?
Please add a comment with an explanation around this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
