dejankrak-db commented on code in PR #50434: URL: https://github.com/apache/spark/pull/50434#discussion_r2017501529
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveDDLCommandStringTypes.scala: ########## @@ -46,6 +46,9 @@ object ResolveDDLCommandStringTypes extends Rule[LogicalPlan] { case createTable: CreateTable if createTable.tableSpec.collation.isDefined => StringType(createTable.tableSpec.collation.get) + case replaceTable: ReplaceTable if replaceTable.tableSpec.collation.isDefined => Review Comment: Does ReplaceTable cover REPLACE VIEW command as well? If so, it would be good to add in the comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org