HyukjinKwon opened a new pull request, #50416:
URL: https://github.com/apache/spark/pull/50416

   ### What changes were proposed in this pull request?
   
   This PR adds a check if the commits add/fix jars, and reject.
   
   ### Why are the changes needed?
   
   It is discouraged to have jars in the repo.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No, dev-only.
   
   ### How was this patch tested?
   
   l manually tested with the jar removal 
(https://github.com/apache/spark/commit/82f75fec4bdd58d45f6d69c2c18bbe097590caf4)
 and changing `dev/test-jars.txt` and:
   
   ```
   APACHE_SPARK_REF=HEAD~1 dev/is-changed.py
   ```
   
   It will fails as below:
   
   ```
   Cannot include jars in source codes. If this has to be added temporarily, 
please add the file name into dev/test-jars.txt.
   ```
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   No.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to