yaooqinn commented on code in PR #50416:
URL: https://github.com/apache/spark/pull/50416#discussion_r2015432293
##########
dev/is-changed.py:
##########
@@ -65,6 +65,20 @@ def main():
changed_files = identify_changed_files_from_git_commits(
os.environ["GITHUB_SHA"], target_ref=os.environ["GITHUB_PREV_SHA"]
)
+
+ if any(f.endswith(".jar") for f in changed_files):
+ with open(
+ os.path.join(os.path.dirname(os.path.realpath(__file__)),
"test-jars.txt")
+ ) as jarlist:
+ inter = set((line.strip() for line in
jarlist.readlines())).intersection(
+ set(changed_files)
+ )
+ if len(inter) > 0:
+ raise SystemExit(
+ "Cannot include jars in source codes. If this has to be
added temporarily, "
+ "please add the file name into dev/test-jars.txt."
Review Comment:
Maybe we should mention that the author needs to add an assumption of the
artifact's existence for related tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
