cloud-fan commented on code in PR #50407: URL: https://github.com/apache/spark/pull/50407#discussion_r2015165311
########## sql/core/src/test/scala/org/apache/spark/sql/execution/command/v1/DescribeTableSuite.scala: ########## @@ -548,6 +547,9 @@ trait DescribeTableSuiteBase extends command.DescribeTableSuiteBase |""".stripMargin spark.sql(tableCreationStr) val viewType = if (isTemp) "TEMP VIEW" else "VIEW" + spark.sql("SET spark.sql.ansi.enabled = false") // non-default + spark.sql("SET spark.sql.parquet.enableVectorizedReader = true") // default + spark.sql("SET spark.sql.sources.fileCompressionFactor = 2.0") // non-default Review Comment: nit: in tests we should use `WithSQLConf` to set configs, so that it can restore the configs at the end. Otherwise these configs will affect other tests that use the same session. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org