asl3 commented on code in PR #50407:
URL: https://github.com/apache/spark/pull/50407#discussion_r2014779236
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/command/v1/DescribeTableSuite.scala:
##########
@@ -548,6 +547,7 @@ trait DescribeTableSuiteBase extends
command.DescribeTableSuiteBase
|""".stripMargin
spark.sql(tableCreationStr)
val viewType = if (isTemp) "TEMP VIEW" else "VIEW"
+ spark.sql(s"SET spark.sql.ansi.enabled = true")
Review Comment:
Sounds good, I'll add more confs to the test.
Noting that all confs which are set explicitly will be included as long as
they are not in the denyList (or included in the allowList below)
[here](https://github.com/apache/spark/blob/400b4d00ac175d87e9eacbdea055f9c9908566ea/sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala#L414),
and additionally timeZone will always be included. So for this case ANSI conf
is included regardless if I set it to true/false:
```
"view_creation_confs":{"spark.sql.ansi.enabled":"false","spark.sql.session.timeZone":"America/Los_Angeles","spark.sql.legacy.useV1Command":"false","spark.sql.parquet.fieldId.read.enabled":"true"}}
```
^ the other confs are ones set by the suite set-up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
