mihailotim-db commented on code in PR #50366:
URL: https://github.com/apache/spark/pull/50366#discussion_r2011525007
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleExecutor.scala:
##########
@@ -30,7 +30,7 @@ import org.apache.spark.sql.internal.SQLConf
import org.apache.spark.util.Utils
object RuleExecutor {
- protected val queryExecutionMeter = QueryExecutionMetering()
+ protected val queryExecutionMeter = QueryExecutionMetering.INSTANCE
Review Comment:
We want to separate `QueryExecutionMetering.INSTANCE` to a separate object
because we want to reuse the same object in fixed-point and single-pass, but at
the same time decouple single-pass from anything that has to do with
`RuleExecutor`. I don't know if that answers your question
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
