LuciferYang commented on code in PR #50366:
URL: https://github.com/apache/spark/pull/50366#discussion_r2010124552
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/QueryExecutionMetering.scala:
##########
@@ -108,6 +108,12 @@ case class QueryExecutionMetering() {
}
}
+object QueryExecutionMetering {
+ private val _queryExecutionMeter = QueryExecutionMetering()
+
+ def queryExecutionMeter: QueryExecutionMetering = _queryExecutionMeter
Review Comment:
Is this in preparation for other subsequent PRs? Will `queryExecutionMeter`
be invoked/used elsewhere?
How about defining it directly as
```
object QueryExecutionMetering {
val queryExecutionMeter = QueryExecutionMetering()
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
