siying commented on code in PR #50344: URL: https://github.com/apache/spark/pull/50344#discussion_r2010731274
########## sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDB.scala: ########## @@ -73,7 +72,8 @@ class RocksDB( hadoopConf: Configuration = new Configuration, loggingId: String = "", useColumnFamilies: Boolean = false, - enableStateStoreCheckpointIds: Boolean = false) extends Logging { + enableStateStoreCheckpointIds: Boolean = false, + partitionId: Int = 0) extends Logging { Review Comment: Oh I didn't realized we need to pass one more thing there. I see some points on the refactoring. But I think it will be nice to separate refactoring from bug fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org