liviazhu-db commented on code in PR #50344:
URL: https://github.com/apache/spark/pull/50344#discussion_r2010716507
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDB.scala:
##########
@@ -60,23 +60,25 @@ case object StoreTaskCompletionListener extends
RocksDBOpType("store_task_comple
*
* @note This class is not thread-safe, so use it only from one thread.
* @see [[RocksDBFileManager]] to see how the files are laid out in local disk
and DFS.
- * @param dfsRootDir Remote directory where checkpoints are going to be
written
* @param conf Configuration for RocksDB
+ * @param stateStoreId StateStoreId for the state store
* @param localRootDir Root directory in local disk that is used to working
and checkpointing dirs
* @param hadoopConf Hadoop configuration for talking to the remote file
system
- * @param loggingId Id that will be prepended in logs for isolating
concurrent RocksDBs
*/
class RocksDB(
- dfsRootDir: String,
val conf: RocksDBConf,
+ stateStoreId: StateStoreId,
Review Comment:
Sure. I undid the refactoring and pass in partitionId as an argument to the
RocksDB constructor instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
