HyukjinKwon commented on code in PR #50347:
URL: https://github.com/apache/spark/pull/50347#discussion_r2009941862
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala:
##########
@@ -422,6 +422,13 @@ trait CheckAnalysis extends LookupCatalog with
QueryErrorsBase with PlanToString
e.invalidFormat(checkRes)
}
+ case parseToTimestamp: ParseToTimestamp if
parseToTimestamp.left.dataType != StringType =>
Review Comment:
I think the problem is that it is a breaking change .. I would leave it to
@srielau tho.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
