MaxGekk commented on code in PR #50347:
URL: https://github.com/apache/spark/pull/50347#discussion_r2008698559
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala:
##########
@@ -422,6 +422,13 @@ trait CheckAnalysis extends LookupCatalog with
QueryErrorsBase with PlanToString
e.invalidFormat(checkRes)
}
+ case parseToTimestamp: ParseToTimestamp if
parseToTimestamp.left.dataType != StringType =>
Review Comment:
ParseToTimestamp should support numeric, see
https://github.com/apache/spark/pull/35887. cc @HyukjinKwon
And I am not sure that checking parameters of particular expression here in
`checkAnalysis` is right approach. IMHO, `ParseToTimestamp` should care of them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
