cashmand commented on code in PR #50270:
URL: https://github.com/apache/spark/pull/50270#discussion_r1999704842
##########
common/variant/src/main/java/org/apache/spark/types/variant/Variant.java:
##########
@@ -325,6 +330,14 @@ static void toJsonImpl(byte[] value, byte[] metadata, int
pos, StringBuilder sb,
case DATE:
appendQuoted(sb, LocalDate.ofEpochDay((int) VariantUtil.getLong(value,
pos)).toString());
break;
+ case TIMESTAMP_NANOS:
+ appendQuoted(sb, TIMESTAMP_FORMATTER.format(
Review Comment:
Yes, it should be covered in the tests. I don't think there's anything in
the current formatter that limits it to microseconds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
