cashmand commented on code in PR #50270:
URL: https://github.com/apache/spark/pull/50270#discussion_r1999684637


##########
common/variant/src/main/java/org/apache/spark/types/variant/VariantUtil.java:
##########
@@ -123,6 +123,12 @@ public class VariantUtil {
   // Long string value. The content is (4-byte little-endian unsigned integer 
representing the
   // string size) + (size bytes of string content).
   public static final int LONG_STR = 16;
+  // Similar to TIMESTAMP, but the 8-byte value represents the number of 
nanoseconds since the

Review Comment:
   Yes. I believe it's based on Iceberg 
(https://iceberg.apache.org/spec/#parquet), which uses the int64 physical type. 
Unfortunately, I don't see the valid range clearly specified there or in the 
Variant spec, but I think the entire 593 year range should be valid.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to