MaxGekk commented on PR #50296: URL: https://github.com/apache/spark/pull/50296#issuecomment-2729685404
> I’ll keep using the existing Minute expression (or rename it to MinuteForTimestamp). @the-sakthi Let's leave it as is. > Then, in the function registry, I’ll dispatch to either MinuteForTime or MinuteForTimestamp based on the input data type. Could you introduce new expression `MinutesOfTime` and place it to `timeExpressions.scala` (see https://github.com/apache/spark/pull/50287). `MinuteOfTime` should extend `RuntimeReplaceable` and use `Invoke`. The last one just invokes `getMinutesOfTime` from `DateTimeUtils`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
