the-sakthi commented on code in PR #50296:
URL: https://github.com/apache/spark/pull/50296#discussion_r1998660187


##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/DateExpressionsSuite.scala:
##########
@@ -388,6 +388,44 @@ class DateExpressionsSuite extends SparkFunSuite with 
ExpressionEvalHelper {
     }
   }
 
+  test("Minute with TIME type") {
+    // A few test times in microseconds since midnight:
+    //   (time in microseconds, expected minute)
+    val secondsPerHour = 3600L
+    val secondsPerMinute = 60L
+    val testTimes = Seq(
+      (0L, 0), // 00:00:00 => 0
+      ((12L * secondsPerHour + 58L * secondsPerMinute + 59L) * 1000000L, 58), 
// 12:58:59 => 58

Review Comment:
   Sure.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to