stefankandic commented on code in PR #50192:
URL: https://github.com/apache/spark/pull/50192#discussion_r1996434982
##########
sql/core/src/test/resources/sql-tests/analyzer-results/collations.sql.out:
##########
@@ -821,15 +821,15 @@ InsertIntoHadoopFsRelationCommand file:[not included in
comparison]/{warehouse_d
-- !query
select concat_ws(' ', utf8_lcase, utf8_lcase) from t5
-- !query analysis
-Project [concat_ws( , utf8_lcase#x, utf8_lcase#x) AS concat_ws( , utf8_lcase,
utf8_lcase)#x]
+Project [concat_ws( , utf8_lcase#x, utf8_lcase#x) AS concat_ws(' ' collate
UTF8_LCASE, utf8_lcase, utf8_lcase)#x]
+- SubqueryAlias spark_catalog.default.t5
+- Relation spark_catalog.default.t5[s#x,utf8_binary#x,utf8_lcase#x] parquet
-- !query
select concat_ws(' ', utf8_binary, utf8_lcase) from t5
-- !query analysis
-Project [concat_ws( , cast(utf8_binary#x as string collate null),
cast(utf8_lcase#x as string collate null)) AS concat_ws( , utf8_binary,
utf8_lcase)#x]
+Project [concat_ws( , cast(utf8_binary#x as string collate null),
cast(utf8_lcase#x as string collate null)) AS concat_ws(' ' collate null,
utf8_binary, utf8_lcase)#x]
Review Comment:
this is the expected behavior when you concat two values with different
collation - the result is an indeterminate collation; you can print it or
collate it explicitly but you can't store in anywhere
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
