vladimirg-db opened a new pull request, #50192:
URL: https://github.com/apache/spark/pull/50192
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR:
https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a
faster review.
7. If you want to add a new configuration, please read the guideline first
for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the
guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
Reassign Aliases for collated expression trees deterministically at the end
of Analysis.
### Why are the changes needed?
Consider the following collated queries and their schemas:
1.
```
SELECT 'a' COLLATE UTF8_LCASE < 'A'
->
(collate(a, UTF8_LCASE) < 'A' collate UTF8_LCASE)
```
2.
```
SELECT CONCAT_WS('a', col1, col1) FROM VALUES ('a' COLLATE UTF8_LCASE)
->
concat_ws(a, col1, col1)
```
The 1. case has an explicit alias where 'A' literal is marked as collated,
which is correct. However, in the second case, 'a' literal is not marked as
collated in the output implicit alias, despite the fact that it is indeed
collated by `CollationTypeCoercion`. The 2. output schema has to be
`concat_ws('a' collate UTF8_LCASE, col1, col1)|`.
### Does this PR introduce _any_ user-facing change?
Yes, implicit aliases of collated expression trees now change. This is a
breaking change.
### How was this patch tested?
Golden files were regenerated
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
