HeartSaVioR commented on PR #50272: URL: https://github.com/apache/spark/pull/50272#issuecomment-2723004044
It's better to retain both types of implementations since we want to "optionally" have close() so we should have covered both cases on testing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org