bogao007 commented on PR #50272: URL: https://github.com/apache/spark/pull/50272#issuecomment-2722873069
> nits: There seem to be more places that could remove the unnecessary `close()` impl in test file: e.g. > > https://github.com/apache/spark/blob/ccfc0a9dcea8fa9d6aab4dbb233f8135a3947441/python/pyspark/sql/tests/pandas/test_pandas_transform_with_state.py#L1479 Yeah I tend to keep both in the test. Removing some `close()` should be able to verify. Do you think we should remove all the `close()` instead? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
