viirya commented on code in PR #10: URL: https://github.com/apache/spark-connect-swift/pull/10#discussion_r1990676843
########## Sources/SparkConnect/DataFrame.swift: ########## @@ -0,0 +1,195 @@ +// +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. +// +import Atomics +import Foundation +import GRPCCore +import GRPCNIOTransportHTTP2 +import GRPCProtobuf +import NIOCore +import SwiftyTextTable +import Synchronization + +/// A DataFrame which supports only SQL queries +public actor DataFrame: Sendable { + var spark: SparkSession + var plan: Plan + var schema: DataType? = nil + private var batches: [RecordBatch] = [RecordBatch]() + + /// Create a new `DataFrame`instance with the given Spark session and plan. + /// - Parameters: + /// - spark: A ``SparkSession`` instance to use. + /// - plan: A plan to execute. + init(spark: SparkSession, plan: Plan) async throws { + self.spark = spark + self.plan = plan + } + + /// Create a new `DataFrame` instance with the given SparkSession and a SQL statement. + /// - Parameters: + /// - spark: A `SparkSession` instance to use. + /// - sqlText: A SQL statement. + init(spark: SparkSession, sqlText: String) async throws { + self.spark = spark + self.plan = sqlText.toSparkConnectPlan + } + + /// Set the schema. This is used to store the analized schema response from `Spark Connect` server. + /// - Parameter schema: <#schema description#> + private func setSchema(_ schema: DataType) { + self.schema = schema + } + + /// Add `Apache Arrow`'s `RecordBatch`s to the intenal array. Review Comment: ```suggestion /// Add `Apache Arrow`'s `RecordBatch`s to the internal array. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
