dongjoon-hyun commented on code in PR #10: URL: https://github.com/apache/spark-connect-swift/pull/10#discussion_r1990696675
########## Tests/SparkConnectTests/SparkSessionTests.swift: ########## @@ -0,0 +1,74 @@ +// +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. +// + +import Foundation +import Testing + +@testable import SparkConnect + +/// A test suite for `SparkSession` +struct SparkSessionTests { + @Test + func sparkContext() async throws { + let spark = try await SparkSession.builder.getOrCreate() + await #expect(throws: SparkConnectError.UnsupportedOperationException) { + try await spark.sparkContext + } + await spark.stop() + } + + @Test + func stop() async throws { + let spark = try await SparkSession.builder.getOrCreate() + await spark.stop() + } + + @Test func userContext() async throws { + let spark = try await SparkSession.builder.getOrCreate() + let defaultUserContext = ProcessInfo.processInfo.userName.toUserContext + #expect(await spark.client.userContext == defaultUserContext) + await spark.stop() + } + + @Test + func version() async throws { + let spark = try await SparkSession.builder.getOrCreate() + #expect(await spark.version.starts(with: "4.0.0")) + await spark.stop() + } + + @Test + func conf() async throws { + let spark = try await SparkSession.builder.getOrCreate() + #expect(try await spark.conf.get("spark.app.name") == "Spark Connect server") + try await spark.conf.set("spark.x", "y") + #expect(try await spark.conf.get("spark.x") == "y") + #expect(try await spark.conf.getAll().count > 10) + await spark.stop() + } + + @Test + func range() async throws { + let spark = try await SparkSession.builder.getOrCreate() + #expect(try await spark.range(10).count() == 10) Review Comment: Yes, it works with the real server from now. Please see here. - https://swiftpackageindex.com/dongjoon-hyun/spark-connect-swift -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
