dongjoon-hyun commented on code in PR #50206:
URL: https://github.com/apache/spark/pull/50206#discussion_r1986220526
##########
.github/workflows/build_maven_java21_macos15.yml:
##########
@@ -36,5 +36,9 @@ jobs:
os: macos-15
envs: >-
{
- "OBJC_DISABLE_INITIALIZE_FORK_SAFETY": "YES"
+ "OBJC_DISABLE_INITIALIZE_FORK_SAFETY": "YES",
+ "TEST_SQL_SHUFFLE_EXCHANGE_MAX_THREAD_THRESHOLD": "256",
+ "TEST_SQL_RESULT_QUERY_STAGE_MAX_THREAD_THRESHOLD": "256",
+ "TEST_HIVE_SHUFFLE_EXCHANGE_MAX_THREAD_THRESHOLD": "48",
+ "TEST_HIVE_RESULT_QUERY_STAGE_MAX_THREAD_THRESHOLD": "48"
Review Comment:
This looks better. In order to avoid any potential conflicts, shall we use
`SPARK_TEST_` prefix instead of `TEST_` prefix, @LuciferYang ?
```
$ git grep SPARK_TEST_
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala:
(if (Utils.isTesting) Seq("SPARK_TEST_HADOOP_CONF_DIR") else Nil)
resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/YarnClusterSuite.scala:
extraEnv = Map("SPARK_TEST_HADOOP_CONF_DIR" ->
customConf.getAbsolutePath()))
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala:
private val sparkTestingDir =
Option(System.getProperty(SPARK_TEST_CACHE_DIR_SYSTEM_PROPERTY))
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala:
if
(Option(System.getProperty(SPARK_TEST_CACHE_DIR_SYSTEM_PROPERTY)).isEmpty) {
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala:
private val SPARK_TEST_CACHE_DIR_SYSTEM_PROPERTY = "spark.test.cache-dir"
sql/hive/src/test/scala/org/apache/spark/sql/hive/client/HiveClientVersions.scala:
private val testVersions = sys.env.get("SPARK_TEST_HIVE_CLIENT_VERSIONS")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
