LuciferYang commented on code in PR #50206:
URL: https://github.com/apache/spark/pull/50206#discussion_r1985261482


##########
sql/core/src/test/scala/org/apache/spark/sql/test/SharedSparkSession.scala:
##########
@@ -79,6 +80,15 @@ trait SharedSparkSessionBase
       StaticSQLConf.WAREHOUSE_PATH,
       conf.get(StaticSQLConf.WAREHOUSE_PATH) + "/" + getClass.getCanonicalName)
     conf.set(StaticSQLConf.LOAD_SESSION_EXTENSIONS_FROM_CLASSPATH, false)
+    // SPARK-51365: Due to the fact that the GitHub-hosted Runner on the 
`macOS + AppleSilicon chip`
+    // combination has only half the memory resources of Runners with other 
specifications,
+    // it is necessary to limit the number of threads in this case to avoid 
the issue of
+    // memory resources being exhausted by frequent thread creation during 
testing.
+    if (sys.env.contains("GITHUB_ACTIONS") && Utils.isMacOnAppleSilicon) {

Review Comment:
   Since similar issues haven't occurred in other pipelines, in this PR I've 
only increased the limit on the number of threads for the currently failing 
test scenario.
   
   cc @dongjoon-hyun Do you think this is ok?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to