anoopj commented on PR #50137: URL: https://github.com/apache/spark/pull/50137#issuecomment-2726783327
@cloud-fan @aokolnychyi I have updated the PR based on Wenchen's suggestion. Please note that I made `TableBuilder` a concrete class so that we can have a default implementation for connectors who don't want to override anything. But that meant that the `TableCatalog` needs to be a constructor argument to the builder. The alternative would have been to make it an abstract class and having a concrete default implementation. PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
