viirya commented on code in PR #50159:
URL: https://github.com/apache/spark/pull/50159#discussion_r1983788372
##########
python/pyspark/sql/connect/client/core.py:
##########
@@ -666,7 +666,7 @@ def __init__(
elif user_id is not None:
self._user_id = user_id
else:
- self._user_id = os.getenv("USER", None)
+ self._user_id = os.getenv("SPARK_USER", os.getenv("USER", None))
Review Comment:
Btw, I think this PR fixes `SparkConnectClient`, and the description also
shows `pyspark` respects default user when `--user_id` is not given. Why this
change to `core.py` is needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
