HyukjinKwon commented on code in PR #50159:
URL: https://github.com/apache/spark/pull/50159#discussion_r1980500141
##########
sql/connect/common/src/main/scala/org/apache/spark/sql/connect/client/SparkConnectClient.scala:
##########
@@ -423,7 +423,6 @@ object SparkConnectClient {
def configuration: Configuration = _configuration
def userId(id: String): Builder = {
- // TODO this is not an optional field!
Review Comment:
We might also need to fix `SparkConnectClient.__init__` here:
```
self._user_id = os.getenv("USER", None)
```
to
```
self._user_id = os.getenv("SPARK_USER", os.getenv("USER", None))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
