beliefer commented on code in PR #50143:
URL: https://github.com/apache/spark/pull/50143#discussion_r1982842931
##########
sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala:
##########
@@ -413,7 +413,7 @@ abstract class JdbcDialect extends Serializable with
Logging {
override def visitSQLFunction(funcName: String, inputs: Array[String]):
String = {
Review Comment:
I want the visitSQLFunction of JDBCSQLBuilder could support the unified
check for supported functions.
```
if (isSupportedFunction(funcName)) {
// compiled DIY
} else {
throw new SparkUnsupportedOperationException.
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
