beliefer commented on code in PR #50143:
URL: https://github.com/apache/spark/pull/50143#discussion_r1981363472
##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/util/V2ExpressionSQLBuilder.java:
##########
@@ -273,11 +273,11 @@ protected String visitCaseWhen(String[] children) {
return sb.toString();
}
- protected String visitSQLFunction(String funcName, String[] inputs) {
+ public String visitSQLFunction(String funcName, String[] inputs) {
return joinArrayToString(inputs, ", ", funcName + "(", ")");
}
- protected String visitAggregateFunction(
+ public String visitAggregateFunction(
Review Comment:
I change `visitSQLFunction` and `visitAggregateFunction` to public due to
the mina error.
```
[error] spark-sql: Failed binary compatibility check against
org.apache.spark:spark-sql_2.13:3.5.0! Found 5 potential problems (filtered
1443)
[error] * method
visitAggregateFunction(java.lang.String,Boolean,Array[java.lang.String])java.lang.String
in class org.apache.spark.sql.connector.util.V2ExpressionSQLBuilder is
inaccessible in current version, it must be public.
[error] filter with:
ProblemFilters.exclude[InaccessibleMethodProblem]("org.apache.spark.sql.connector.util.V2ExpressionSQLBuilder.visitAggregateFunction")
[error] * method
visitAggregateFunction(java.lang.String,Boolean,Array[java.lang.String])java.lang.String
in class org.apache.spark.sql.connector.util.V2ExpressionSQLBuilder is
inaccessible in current version, it must be public.
[error] filter with:
ProblemFilters.exclude[InaccessibleMethodProblem]("org.apache.spark.sql.connector.util.V2ExpressionSQLBuilder.visitAggregateFunction")
[error] * method
visitSQLFunction(java.lang.String,Array[java.lang.String])java.lang.String in
class org.apache.spark.sql.connector.util.V2ExpressionSQLBuilder is
inaccessible in current version, it must be public.
[error] filter with:
ProblemFilters.exclude[InaccessibleMethodProblem]("org.apache.spark.sql.connector.util.V2ExpressionSQLBuilder.visitSQLFunction")
[error] * method
visitAggregateFunction(java.lang.String,Boolean,Array[java.lang.String])java.lang.String
in class org.apache.spark.sql.connector.util.V2ExpressionSQLBuilder is
inaccessible in current version, it must be public.
[error] filter with:
ProblemFilters.exclude[InaccessibleMethodProblem]("org.apache.spark.sql.connector.util.V2ExpressionSQLBuilder.visitAggregateFunction")
[error] * method
visitAggregateFunction(java.lang.String,Boolean,Array[java.lang.String])java.lang.String
in class org.apache.spark.sql.connector.util.V2ExpressionSQLBuilder is
inaccessible in current version, it must be public.
[error] filter with:
ProblemFilters.exclude[InaccessibleMethodProblem]("org.apache.spark.sql.connector.util.V2ExpressionSQLBuilder.visitAggregateFunction")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
