beliefer commented on code in PR #50020:
URL: https://github.com/apache/spark/pull/50020#discussion_r1982637434
##########
core/src/main/scala/org/apache/spark/BarrierCoordinator.scala:
##########
@@ -53,8 +54,9 @@ private[spark] class BarrierCoordinator(
// TODO SPARK-25030 Create a Timer() in the mainClass submitted to
SparkSubmit makes it unable to
// fetch result, we shall fix the issue.
- private lazy val timer = ThreadUtils.newSingleThreadScheduledExecutor(
+ private lazy val timer = ThreadUtils.newDaemonSingleThreadScheduledExecutor(
"BarrierCoordinator barrier epoch increment timer")
+ private val timerFutures = Collections.synchronizedList(new
ArrayList[ScheduledFuture[_]])
Review Comment:
I'm a bit concern for the potential memory leak as @srowen said at
https://github.com/apache/spark/pull/50107#discussion_r1979417965
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
