jayadeep-jayaraman commented on code in PR #50020:
URL: https://github.com/apache/spark/pull/50020#discussion_r1981439320
##########
core/src/main/scala/org/apache/spark/BarrierCoordinator.scala:
##########
@@ -55,6 +55,7 @@ private[spark] class BarrierCoordinator(
// fetch result, we shall fix the issue.
private lazy val timer = ThreadUtils.newSingleThreadScheduledExecutor(
"BarrierCoordinator barrier epoch increment timer")
+ private var timerFuture: Option[ScheduledFuture[_]] = None
Review Comment:
Good point, I think I will use
[CopyOnWriteArrayList](http://download.oracle.com/javase/7/docs/api/java/util/concurrent/CopyOnWriteArrayList.html)
to hold the futures. What do you think ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
