beliefer commented on code in PR #50107:
URL: https://github.com/apache/spark/pull/50107#discussion_r1975351020
##########
core/src/main/scala/org/apache/spark/ui/ConsoleProgressBar.scala:
##########
@@ -121,5 +121,8 @@ private[spark] class ConsoleProgressBar(sc: SparkContext)
extends Logging {
* Tear down the timer thread. The timer thread is a GC root, and it
retains the entire
* SparkContext if it's not terminated.
*/
- def stop(): Unit = ThreadUtils.shutdown(timer)
+ def stop(): Unit = {
+ timerFuture.cancel(true)
+ ThreadUtils.shutdown(timer)
+ }
Review Comment:
Good question!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
