beliefer commented on code in PR #50107:
URL: https://github.com/apache/spark/pull/50107#discussion_r1973643904
##########
core/src/main/scala/org/apache/spark/BarrierTaskContext.scala:
##########
@@ -300,11 +300,7 @@ object BarrierTaskContext {
@Since("2.4.0")
def get(): BarrierTaskContext =
TaskContext.get().asInstanceOf[BarrierTaskContext]
- private val timer = {
- val executor = ThreadUtils.newDaemonSingleThreadScheduledExecutor(
- "Barrier task timer for barrier() calls.")
- assert(executor.isInstanceOf[ScheduledThreadPoolExecutor])
- executor.asInstanceOf[ScheduledThreadPoolExecutor]
- }
+ private val timer = ThreadUtils.newSingleThreadScheduledExecutor(
Review Comment:
The origin code is non-daemon thread here.
Please see
https://github.com/apache/spark/commit/5d5b3a54b7b5fb4308fe40da696ba805c72983fc#diff-e9f66d336ded6632366be06dbd70e74afe9595cfc92a962f2c8554f09af53d0fL286
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
