cloud-fan commented on code in PR #50079:
URL: https://github.com/apache/spark/pull/50079#discussion_r1969891707
##########
sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala:
##########
@@ -2779,6 +2779,23 @@ class DatasetSuite extends QueryTest
}
}
+ test("SPARK-51312: createDataFrame should work with both Date and
LocalDate") {
+ val testCases = Seq(
+ ("true", Array(Row(java.time.LocalDate.of(2020, 5, 13)),
+ Row(java.time.LocalDate.of(2020, 5, 13)))),
Review Comment:
oh it's already this way, but why do we need the `testCases`? The expected
result is simply `sql("SELECT DATE'2020-05-13', ...")`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
