cloud-fan commented on code in PR #50079: URL: https://github.com/apache/spark/pull/50079#discussion_r1969887781
########## sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala: ########## @@ -2779,6 +2779,23 @@ class DatasetSuite extends QueryTest } } + test("SPARK-51312: createDataFrame should work with both Date and LocalDate") { + val testCases = Seq( + ("true", Array(Row(java.time.LocalDate.of(2020, 5, 13)), + Row(java.time.LocalDate.of(2020, 5, 13)))), Review Comment: let's write the test this way: - the input row has two columns: one is `LocalDate` and one is `Date` - we run the test twice with the java8 datetime api on and off. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org