dusantism-db commented on code in PR #50024:
URL: https://github.com/apache/spark/pull/50024#discussion_r1964036632


##########
sql/core/src/test/scala/org/apache/spark/sql/scripting/SqlScriptingE2eSuite.scala:
##########
@@ -139,6 +147,24 @@ class SqlScriptingE2eSuite extends QueryTest with 
SharedSparkSession {
     verifySqlScriptResult(sqlScript, Seq.empty)
   }
 
+  test("script with empty result") {
+    withTable("scripting_test_table") {
+      val sqlScript =
+        """
+          |BEGIN
+          |  CREATE TABLE scripting_test_table (id INT);
+          |  SELECT * FROM scripting_test_table;
+          |  DROP TABLE scripting_test_table;

Review Comment:
   Nit: Doesn't `withTable` drop this table already?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to