dusantism-db commented on code in PR #50024:
URL: https://github.com/apache/spark/pull/50024#discussion_r1964034097
##########
sql/core/src/test/scala/org/apache/spark/sql/scripting/SqlScriptingE2eSuite.scala:
##########
@@ -35,9 +36,16 @@ import org.apache.spark.sql.test.SharedSparkSession
*/
class SqlScriptingE2eSuite extends QueryTest with SharedSparkSession {
// Helpers
- private def verifySqlScriptResult(sqlText: String, expected: Seq[Row]): Unit
= {
+ private def verifySqlScriptResult(
+ sqlText: String,
+ expected: Seq[Row],
+ expectedSchema: Option[StructType] = None): Unit = {
val df = spark.sql(sqlText)
checkAnswer(df, expected)
+
+ if (expectedSchema.isDefined) {
Review Comment:
Nit:
`assert(expectedSchema.forall(_ === df.schema))`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
