HeartSaVioR commented on code in PR #50015: URL: https://github.com/apache/spark/pull/50015#discussion_r1963426428
########## sql/core/src/test/scala/org/apache/spark/sql/execution/QueryExecutionSuite.scala: ########## @@ -422,6 +422,24 @@ class QueryExecutionSuite extends SharedSparkSession { mockCallback.assertAnalyzed() } + test("SPARK-51265 Running eagerlyExecuteCommand with streaming source should give an user " + + "facing error") { + withTempView("s") { + val streamDf = spark.readStream.format("rate").load() + streamDf.createOrReplaceTempView("s") + withTable("output") { + val ex = intercept[AnalysisException] { + // Creates a table from streaming source with batch query. This should fail. + spark.sql("CREATE TABLE output AS SELECT * FROM s") Review Comment: Yes, it went with stack overflow, and for this case we might be OK. Thuogh I wouldn't assume this is the only case - this is a minimized reproducer of the report, and origin report was ended up with AnalysisException with INTERNAL_ERROR (it was even from different command). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org