HeartSaVioR commented on PR #50015: URL: https://github.com/apache/spark/pull/50015#issuecomment-2670792107
I realized the downside of the fix - if we were ever planning to unify the logical plan for write between batch and streaming (at least DSv2 path), it wouldn't work. For now, streaming write node is always either WriteToMicroBatchDataSource or WriteToMicroBatchDataSourceV1, so wouldn't be problematic with this change. Though I don't have a clear way to resolve the above I commented, so unless someone has brilliant idea to resolve the coupling, maybe we may need to live with it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
