anishshri-db commented on code in PR #49304: URL: https://github.com/apache/spark/pull/49304#discussion_r1960633610
########## sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/RocksDBSuite.scala: ########## @@ -918,18 +968,34 @@ class RocksDBSuite extends AlsoTestWithRocksDBFeatures with SharedSparkSession } // Check that snapshots and changelogs get purged correctly. db.doMaintenance() - assert(snapshotVersionsPresent(remoteDir) === Seq(30, 60)) + + if (enableStateStoreCheckpointIds && colFamiliesEnabled) { Review Comment: No - one is checking for snapshot version and the other for changelog version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org