anishshri-db commented on code in PR #49304:
URL: https://github.com/apache/spark/pull/49304#discussion_r1960644385
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBStateEncoder.scala:
##########
@@ -1791,16 +1644,12 @@ class RangeKeyScanStateEncoder(
class NoPrefixKeyStateEncoder(
dataEncoder: RocksDBDataEncoder,
keySchema: StructType,
- useColumnFamilies: Boolean = false,
- columnFamilyInfo: Option[ColumnFamilyInfo] = None)
- extends StateRowPrefixEncoder(
- useColumnFamilies,
- columnFamilyInfo
- ) with RocksDBKeyStateEncoder with Logging {
+ useColumnFamilies: Boolean = false)
+ extends RocksDBKeyStateEncoder with Logging {
override def encodeKey(row: UnsafeRow): Array[Byte] = {
if (!useColumnFamilies) {
Review Comment:
Yes as discussed - this does seem like a bug. So we will retain this
behavior as it is and do the version bump change later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
