pan3793 commented on code in PR #49986:
URL: https://github.com/apache/spark/pull/49986#discussion_r1960038301
##########
mllib/src/main/scala/org/apache/spark/mllib/linalg/BLAS.scala:
##########
@@ -17,44 +17,14 @@
package org.apache.spark.mllib.linalg
-import dev.ludovic.netlib.blas.{BLAS => NetlibBLAS, JavaBLAS =>
NetlibJavaBLAS, NativeBLAS => NetlibNativeBLAS}
-
import org.apache.spark.internal.Logging
+import org.apache.spark.ml.linalg.BLAS.{getBLAS, nativeBLAS}
/**
* BLAS routines for MLlib's vectors and matrices.
*/
private[spark] object BLAS extends Serializable with Logging {
- @transient private var _javaBLAS: NetlibBLAS = _
- @transient private var _nativeBLAS: NetlibBLAS = _
Review Comment:
remove the duplicated instance creation and call
`org.apache.spark.ml.linalg.BLAS`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
