pan3793 commented on code in PR #49986: URL: https://github.com/apache/spark/pull/49986#discussion_r1958978004
########## core/src/main/scala/org/apache/spark/SparkContext.scala: ########## @@ -3436,6 +3437,20 @@ object SparkContext extends Logging { supplement(DRIVER_JAVA_OPTIONS) supplement(EXECUTOR_JAVA_OPTIONS) } + + private def supplementBlasOptions(conf: SparkConf): Unit = { + conf.getOption("spark.ml.allowNativeBlas").foreach { allowNativeBlas => Review Comment: I skimmed the codebase https://github.com/luhenry/netlib and found neither sys prop nor env to disable native blas loading, so I need to introduce a new one. do you mean env var is preferred over sys prop? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org