beliefer commented on code in PR #49453:
URL: https://github.com/apache/spark/pull/49453#discussion_r1959667978
##########
connector/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/v2/MySQLIntegrationSuite.scala:
##########
@@ -264,4 +342,10 @@ class MySQLOverMariaConnectorIntegrationSuite extends
MySQLIntegrationSuite {
s"jdbc:mysql://$ip:$port/mysql?user=root&password=rootpass&allowPublicKeyRetrieval=true"
+
s"&useSSL=false"
}
+
+ // MariaDB Connector/J uses collation 'utf8mb4_unicode_ci' as collation for
connection.
+ // The MySQL server 9.1.0 uses collation 'utf8mb4_0900_ai_ci' for database
by default.
+ // This method uses string literal so the result of cast and literal have
the same collation.
+ override def testCastStringTarget(stringLiteral: String, stringCol: String):
String =
Review Comment:
I'm not sure if this function is good enough to test cast string.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
