vladimirg-db commented on code in PR #49445:
URL: https://github.com/apache/spark/pull/49445#discussion_r1956472572
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/executeImmediate.scala:
##########
@@ -152,9 +154,16 @@ class SubstituteExecuteImmediate(val catalogManager:
CatalogManager)
}
}
+ // Fully analyze the generated plan.
AnalysisContext.withExecuteImmediateContext makes sure
+ // that SQL scripting local variables will not be accessed from the
plan.
+ val finalPlan = AnalysisContext.withExecuteImmediateContext {
+ resolveChild(queryPlan)
+ }
Review Comment:
Invoking the Analyzer recursively on the `EXECUTE IMMEDIATE` plan is a
pretty major change for that functionality.
Please commit it as a separate PR. If it introduces a regression, we would
be able to easily identify that commit in the git log and potentially cleanly
revert it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
