dongjoon-hyun commented on code in PR #49741: URL: https://github.com/apache/spark/pull/49741#discussion_r1936695648
########## sql/catalyst/benchmarks/EnumTypeSetBenchmark-jdk21-results.txt: ########## @@ -1,105 +1,105 @@ -OpenJDK 64-Bit Server VM 21.0.5+11-LTS on Linux 6.8.0-1017-azure +OpenJDK 64-Bit Server VM 21.0.6+7-LTS on Linux 6.8.0-1020-azure AMD EPYC 7763 64-Core Processor Test contains use empty Set: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative ------------------------------------------------------------------------------------------------------------------------ -Use HashSet 3 3 0 291.9 3.4 1.0X -Use EnumSet 4 4 0 227.7 4.4 0.8X +Use HashSet 1 1 0 1390.7 0.7 1.0X Review Comment: Although the ratio changes in both Java 17 and 21. The measure time is too small, `1ms`. So, I believe we can ignore because it means it gets faster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
