hvanhovell commented on code in PR #49339:
URL: https://github.com/apache/spark/pull/49339#discussion_r1936181291


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/ExpressionEncoder.scala:
##########
@@ -49,7 +49,7 @@ import org.apache.spark.util.Utils
 object ExpressionEncoder {
 
   def apply[T : TypeTag](): ExpressionEncoder[T] = {
-    apply(ScalaReflection.encoderFor[T])
+    apply(ScalaReflection.encoderForWithRowEncoderSupport[T])

Review Comment:
   Using it could be useful for UDFs. That would reduce typing issues every so 
slightly. Instead of an unbound data type you would at least know the UDF 
expects a Row to be passed in. For that we would need to do some more work.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to