xupefei commented on code in PR #49339: URL: https://github.com/apache/spark/pull/49339#discussion_r1935348809
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/ExpressionEncoder.scala: ########## @@ -49,7 +49,7 @@ import org.apache.spark.util.Utils object ExpressionEncoder { def apply[T : TypeTag](): ExpressionEncoder[T] = { - apply(ScalaReflection.encoderFor[T]) + apply(ScalaReflection.encoderForWithRowEncoderSupport[T]) Review Comment: Nothing will break. I changed this one because it's from internal code, so just to be safe. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org