LuciferYang commented on PR #49411: URL: https://github.com/apache/spark/pull/49411#issuecomment-2614251183
> * Based on that the root cause for the performance regression of `SubExprEliminationBenchmark` is not due to the codegen implementation of `from_json`(the root cause is that the operator `FilterExEc` did not implement `SubExprElimination` optimization in `WSC`), this PR will close here. > * The operator `FilterExec` implementing `SubExprElimination` optimization in `WSC` is still being explored for implementation: [[Only Test][Don't Review] Make `FilterExec` to support `subexpressionElimination` in the codegen scenario #49573](https://github.com/apache/spark/pull/49573) Got, although the performance result may degrade, I suggest submitting a pr to update the benchmark results of `SubExprEliminationBenchmark ` for Apache Spark 4.0 and leave a TODO. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
