wayneguow commented on code in PR #49564:
URL: https://github.com/apache/spark/pull/49564#discussion_r1929498052
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCOptions.scala:
##########
@@ -321,4 +323,5 @@ object JDBCOptions {
val JDBC_CONNECTION_PROVIDER = newOption("connectionProvider")
val JDBC_PREPARE_QUERY = newOption("prepareQuery")
val JDBC_PREFER_TIMESTAMP_NTZ = newOption("preferTimestampNTZ")
+ val JDBC_HINT_STRING = newOption("hint")
Review Comment:
> Shall we make the option is available for each of the built-in JDBC
dialects ?
Currently, not all underlying JDBC data sources support the `hints` feature,
such as `derby`, `postgresql` (supported by `pg_hint_plan` unofficial). In
addition, `SQLServer` and `DB2` do not support comments-style hints.
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCOptions.scala:
##########
@@ -321,4 +323,5 @@ object JDBCOptions {
val JDBC_CONNECTION_PROVIDER = newOption("connectionProvider")
val JDBC_PREPARE_QUERY = newOption("prepareQuery")
val JDBC_PREFER_TIMESTAMP_NTZ = newOption("preferTimestampNTZ")
+ val JDBC_HINT_STRING = newOption("hint")
Review Comment:
> Shall we make the option is available for each of the built-in JDBC
dialects ?
@beliefer Currently, not all underlying JDBC data sources support the
`hints` feature, such as `derby`, `postgresql` (supported by `pg_hint_plan`
unofficial). In addition, `SQLServer` and `DB2` do not support comments-style
hints.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
